Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kubernetes-common-v2 to shared npm package #13502

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

damccorm
Copy link

@damccorm damccorm commented Sep 2, 2020

Description: Move kubernetes-common-v2 to shared npm package instead of common folder. Source code

Documentation changes required: N

Added unit tests: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@thesattiraju
Copy link
Contributor

You might want to delete kuberenetes-common folder also while you're at it. I'm assuming this is a clean up thing.

Is there a way to ensure the task changes like we do today? Where you change something in the common folder and every dependent task gets flagged for updating the version. How are the changes w.r.t. common modules expected to work?

@damccorm
Copy link
Author

damccorm commented Sep 2, 2020

You might want to delete kuberenetes-common folder also while you're at it. I'm assuming this is a clean up thing.

Yeah, that's part of the plan

Is there a way to ensure the task changes like we do today? Where you change something in the common folder and every dependent task gets flagged for updating the version. How are the changes w.r.t. common modules expected to work?

The expectation is that you don't always have to do that. Basically right now the common folder is acting as an unversioned package store, the goal here is to move all of this to a traditional npm model where you can pin to a specific version and one task's needs don't have to be compatible with every others' to make an upgrade. Basically our entire build system right now is working around the fact that its not a real package store, this gives different tasks flexibility to do this differently.

@damccorm damccorm merged commit 00c2c43 into master Sep 2, 2020
@damccorm damccorm deleted the users/damccorm/kubernetes-common-v2 branch September 2, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants